-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement default selections #70
base: main
Are you sure you want to change the base?
Conversation
33dffd8
to
ee8c64e
Compare
Thanks for this. Will this functionality be available soon? |
This comment has been minimized.
This comment has been minimized.
I can't repro with Leaflet: library(crosstalk)
library(leaflet)
sd <- SharedData$new(quakes)
filt <- filter_select(
id = "mag",
label = "Select magnitude",
sharedData = sd,
group = ~as.integer(mag),
multiple = FALSE,
selected = 5
)
map <- leaflet(sd) %>% addMarkers()
bscols(widths = c(3,9), filt, map) @cpsievert, maybe something for us to take a quick look at together next week. |
This issue is still happening for me, like @paulklemm, using |
For |
It seems that the problem I reported only happens with plotly. See @cpsievert post here: #16 (comment) |
Is this feature has been updated? There is no "selected" argument in the latest CRAN update. |
b420e9f
to
57ab29b
Compare
…, it'll be the widget's responsibility to immediate invoke the change handler when rendering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this more, it seems better for selected
to be specified through SharedData
(either through $new()
or via $selection()
?), not the input controls. The benefit being that we'd also have a way to specify default selections (not just filter)
Hi, can I ask what the status of this PR is? I've been relying in a couple of toy projects on installing the branch version that implements this change, I'd like to use it in some production code (in a non-Shiny rmarkdown project) but would prefer to use the "main" version of the package rather than a branched offshoot. |
Fixes #35.